Skip to content

Add retries option passthrough to SOCKS proxy classes#643

Merged
zanieb merged 2 commits intoencode:masterfrom
zanieb:retry-socks-proxy
Dec 29, 2022
Merged

Add retries option passthrough to SOCKS proxy classes#643
zanieb merged 2 commits intoencode:masterfrom
zanieb:retry-socks-proxy

Conversation

@zanieb
Copy link
Contributor

@zanieb zanieb commented Dec 29, 2022

Required for encode/httpx#2517

The SOCKSProxy and AsyncSOCKSProxy classes document a retries option but do not accept it.

This adds the parameter and passes it through to the connection pool.

Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@zanieb zanieb merged commit d6a96ad into encode:master Dec 29, 2022
@lovelydinosaur lovelydinosaur mentioned this pull request Mar 16, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants